Clean up usage of HTTP mocks in tests.

[dhermes]

This is a follow-on to #602, and partially making good on a comment I made in #586.

I checked the types of http values sent to transport.request by adding:

from tests import http_mock
import types
if type(http) == http_mock.HttpMock:
    pass
elif type(http) == http_mock.HttpMockSequence:
    pass
elif (type(http) == types.MethodType and
      http.__self__.__class__ == http_mock.HttpMock):
    pass
elif (type(http) == types.MethodType and
      http.__self__.__class__ == http_mock.HttpMockSequence):
    pass
elif (type(http) == types.FunctionType and
      http.__name__ == 'new_request'):
    pass
else:
    raise MyErr(http)

I also did git grep http_request to find some other iffy usage. I'd also like to track down usage of http.request (or just .request on an object).

The method type and function type checks are to accommodate the hacky way an http object is monkey-patched, so I'd also like to fix those up as part of #128.

[theacodes]

This looks good to me.

[dhermes]

@jonparrott What do you have against the acronym LGTM 😉

[theacodes]

I don't know.

On Wed, Aug 10, 2016 at 3:09 PM Danny Hermes [email protected]
wrote:

@jonparrott https://github.com/jonparrott What do you have against the
acronym LGTM 😉

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#605 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUc-NkRPCpRWm8flFvwFUQbw2nfwp-ks5qekwTgaJpZM4JhlMl
.