This repository has been archived by the owner on Jan 18, 2025. It is now read-only.
Add asserts for HTTP request mocks in test_gce #600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've seen many diffs base in my time and issue 599 is no diff base. Needs resolution. |
dhermes
force-pushed
the
add-http-asserts
branch
from
7a6ed5d to
9bb93d0
Compare
|
@nathanielmanistaatgoogle I had an off-by-one error. Rebased nonetheless. |
|
I support this change, but it seems to be failing in travis? |
|
Change content looks fine; poke again when pull request 598 is in and tests are passing. |
dhermes
force-pushed
the
add-http-asserts
branch
from
9bb93d0 to
17096f1
Compare
dhermes
force-pushed
the
add-http-asserts
branch
from
17096f1 to
4bc57de
Compare
|
It turns out #602 makes this irrelevant. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Uses #598 as diff base.NOTE: Uses #599 as diff base.