-
Notifications
You must be signed in to change notification settings - Fork 430
Merge util.py and _helpers.py #579
Merge util.py and _helpers.py #579
Conversation
@pferate I am the originator of Also, I seem to recall there being an issue with the LICENSE on that file since it came from Guido on the |
Thanks for the info. I guess I misunderstood your comment from #251:
and assumed that the code in |
Ahh that's a failure of my memory then, the thing I wrote at that time is the real truth. The goal is a smaller surface area, not a larger one and none of the functions in In addition to nuking |
File a bug and put it in the 4.0.0 milestone. |
In general, I'd prefer less public stuff in this library. |
... so is this pull request actionable or should it be closed? Is this where |
I don't see anything in |
Yes that |
OK, I'll update this PR. With |
That is @nathanielmanistaatgoogle's territory (of having more refined opinions than others). IIUC he prefers that imported functions be public, and since the module is non-public, that will be very much OK. (I would suggest holding off of renames like |
I also would prefer Basically, functions that start with |
Thanks! |
7337915
to
328b200
Compare
PR has been updated ( |
328b200
to
943ff6c
Compare
return scopes | ||
|
||
|
||
def _add_query_parameter(url, name, value): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This change looks mostly good to me, @nathanielmanistaatgoogle to do the final review. |
'[email protected] (Guido van Rossum)', | ||
] | ||
|
||
__all__ = [ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Done with my first round of review. |
|
||
# 1 positional arg, 1 keyword-only arg. | ||
@_helpers.positional(1) | ||
def fn(pos, kwonly=None): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
943ff6c
to
3bfeb69
Compare
A new file, `_helpers.py`, was created without realizing that `utils.py` existed for the same purpose. Moving all to `_helpers.py`.
3bfeb69
to
2f5c53b
Compare
PR has been updated. I will be creating another PR to remove the |
A new file,
_helpers.py
, was created without realizing thatutils.py
existed for the same purpose.Resolves: #251, (partially) #428 (partial duplicate of #251)