Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Removing all uses of self.fail(). #430

Merged
merged 1 commit into from
Feb 21, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 20, 2016

Replacing instead with assertRaises statements.

Replacing instead with assertRaises statements.
@dhermes
Copy link
Contributor Author

dhermes commented Feb 20, 2016

This is towards #212. Amazingly enough there are still lines in tests that never get executed / have branch misses:

tests/contrib/test_multistore_file.py : 108->110, 113->-112, 158->-138
tests/test_client.py                  : 311->-311, 329->-329
tests/test_file.py                    : 83->-82, 180->-180, 241->-226
tests/test_service_account.py         : 102->106

Though the test_service_account.py one is a bug in coverage.

@nathanielmanistaatgoogle
Copy link
Contributor

Looks great; thank you for the clean-up and merge when you please.

dhermes added a commit that referenced this pull request Feb 21, 2016
Removing all uses of self.fail().
@dhermes dhermes merged commit c66e4f2 into googleapis:master Feb 21, 2016
@dhermes dhermes deleted the remove-self-fail branch February 21, 2016 17:46
@dhermes dhermes mentioned this pull request Mar 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants