Skip to content
This repository has been archived by the owner on Jan 18, 2025. It is now read-only.

Make _ServiceAccountCredentials public. #397

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 5, 2016

Also

  • changing the svc. acct. creds constructor to take a signer
  • adding two factory constructors to build from a JSON keyfile
    (either by filename or already parsed)
  • adding helpers to avoid re-loading file contents or re-parsing
    JSON when constructing svc. acct. creds from the main
    client module

Also
- changing the svc. acct. creds constructor to take a signer
- adding two factory constructors to build from a JSON keyfile
  (either by filename or already parsed)
- adding helpers to avoid re-loading file contents or re-parsing
  JSON when constructing svc. acct. creds from the main
  `client` module
nathanielmanistaatgoogle added a commit that referenced this pull request Feb 5, 2016
@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit 8518131 into googleapis:master Feb 5, 2016
@dhermes dhermes deleted the consolidate-service-accounts-v2 branch February 12, 2016 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants