This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Fall back to read-only credentials on EACCES errors #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a bug where multiple threads and/or processes using multistore_file on Windows to access the same backing store could raise IOError errno.EACCES to the calling application. This change causes a fallback to read only mode and refreshes credentials if necessary.
|
Can you add a test case for this? |
|
I did in test_multistore_file? |
|
Oh, of course. I get an 'F' for reading comprehension. @dhermes @nathanielmanistaatgoogle this change looks good to me, please take a look. |
nathanielmanistaatgoogle
added a commit
that referenced
this pull request
Jan 29, 2016
Fall back to read-only credentials on EACCES errors.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug where multiple threads and/or processes
using multistore_file on Windows to access the same backing
store could raise IOError errno.EACCES to the calling application.
This change causes a fallback to read only mode and refreshes
credentials if necessary.
Fixes #386