Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Adding dictionary storage for #319. #351

Closed
wants to merge 1 commit into from

Conversation

theacodes
Copy link
Contributor

  • DictionaryStorage - implements an optionally-locked storage over a dictionary-like object.
  • Moved optional locking logic into Storage, previously this has been duplicated in subclasses.
  • Removed flask_util.FlaskSessionStorage and replaced it with DictionaryStorage.

@theacodes
Copy link
Contributor Author

Looks like the django tests are hurting me. I'll rebase once the django fix (#350) is in.

@theacodes
Copy link
Contributor Author

Sigh, failing for different reasons now, I'm going to have to modify the django_util's storage class. I'm going to hold off until #353 is done. No need to make this change while we're still shuffling code around.

@dhermes
Copy link
Contributor

dhermes commented Dec 4, 2015

@waprin and I had discussed (1, 2) this a bit. I think the Django Storage is borken so that might explain it?

@dhermes
Copy link
Contributor

dhermes commented Jan 5, 2016

@jonparrott I killed the build
https://travis-ci.org/google/oauth2client/builds/100446260
to move #378 to the front of the line (since it is a critical error).

I'll try to restart it once #378 is merged and tests have run there.

@theacodes
Copy link
Contributor Author

@dhermes 😢

I definitely wasn't waiting on that for the last hour or anything.

I'll just continue my crusade against httplib2.

@dhermes
Copy link
Contributor

dhermes commented Jan 5, 2016

Haha it seems Travis is batching us to one job at a time so hopefully yours will be the one and only and will start right up.

@dhermes
Copy link
Contributor

dhermes commented Jan 6, 2016

@jonparrott #378 has finally been merged (tests ran at 7:45am Pacific today, 18 or so hours after being created, oy). You should rebase so that your tests don't fail on Python 2.6 (I can restart the original build if you want, but it was going to fail on Python 2.6)

* DictionaryStorage - implements an optionally-locked storage over a dictionary-like object.
* Moved optional locking logic into `Storage`, previously this has been duplicated in subclasses.
* Removed `flask_util.FlaskSessionStorage` and replaced it with `DictionaryStorage`.
@theacodes
Copy link
Contributor Author

Rebased. Waiting on Travis.

@theacodes
Copy link
Contributor Author

Don't review yet. I'm breaking this up into smaller changes.

@dhermes
Copy link
Contributor

dhermes commented Jan 6, 2016

Yay!

@theacodes theacodes closed this Jan 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants