Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Moving CONTRIBUTING out of docs to repository top-level. #244

Merged
merged 1 commit into from
Aug 7, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 7, 2015

Also unifying the old docs/contributing.rst with the current contents of CONTRIBUTING.md.

@nathanielmanistaatgoogle
Copy link
Contributor

"... and into repository" sounds like content is coming into source control from outside, which isn't the case. How about "Move CONTRIBUTING to repository top-level"?

@dhermes dhermes changed the title Moving CONTRIBUTING out of docs and into repository. Moving CONTRIBUTING out of docs to repository top-level. Aug 7, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Aug 7, 2015

@nathanielmanistaatgoogle I also rewrote the original commit to say the same.

While doing it I realized that there is an existing CONTRIBUTING.md, which I added in #155!

I suggest we unify these two documents in a follow-up PR. WDYT?

@dhermes
Copy link
Contributor Author

dhermes commented Aug 7, 2015

I should also mention that you can see the rendered RST on my branch: https://github.com/dhermes/oauth2client/blob/move-contrib/CONTRIBUTING.rst

@nathanielmanistaatgoogle
Copy link
Contributor

Yes; it would be rude of us to maintain CONTRIBUTING.rst and CONTRIBUTING.md as separate documents.

Unifying the old docs/contributing.rst with the current
contents of CONTRIBUTING.md.
@dhermes
Copy link
Contributor Author

dhermes commented Aug 7, 2015

@nathanielmanistaatgoogle I went ahead and merged the two together. Can be seen at: https://github.com/dhermes/oauth2client/blob/move-contrib/CONTRIBUTING.md

@nathanielmanistaatgoogle
Copy link
Contributor

LGTM!

dhermes added a commit that referenced this pull request Aug 7, 2015
Moving CONTRIBUTING out of docs to repository top-level.
@dhermes dhermes merged commit 5a44c8c into googleapis:master Aug 7, 2015
@dhermes dhermes deleted the move-contrib branch August 7, 2015 20:26
@dhermes dhermes mentioned this pull request Aug 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants