Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

In OAuth2Credentials, only pass the first argument as positional. #167

Closed
wants to merge 1 commit into from
Closed

In OAuth2Credentials, only pass the first argument as positional. #167

wants to merge 1 commit into from

Conversation

ryanli
Copy link

@ryanli ryanli commented Apr 20, 2015

So that it doesn't print an warning about extra positional arguments if a request takes at most 1 positional argument (e.g. one that is already authorized by OAuth2Credentials.authorize).

In OAuth2Credentials, pass all arguments except the first as keyword …
5efa2c2 
…arguments.

So that it doesn't print an error about extra positional arguments if a request
is authorized more than once.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 64.94% when pulling 5efa2c2 on ryanli:master into 22a532d on google:master.

@dhermes
Copy link
Contributor

dhermes commented Jun 24, 2015

Thanks for your contribution!

This was addressed (in a different way) in #196.

Sorry we missed this before #196 came through.

@dhermes dhermes closed this Jun 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanli @coveralls @dhermes @googlebot