Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: manually fix release notes for 7.0 #2286

Merged
merged 3 commits into from
Aug 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,15 @@
### ⚠ BREAKING CHANGES

* Make node 14 the minimum supported version ([#2244](https://github.com/googleapis/nodejs-storage/issues/2244))
* Add stronger typings to metadata ([#2234](https://github.com/googleapis/nodejs-storage/issues/2234))
ddelgrosso1 marked this conversation as resolved.
Show resolved Hide resolved
* Remove extend and Treat Provided Options as Mutable ([#2204](https://github.com/googleapis/nodejs-storage/issues/2204))
* Stronger typing for lifecycle rules ([#2215](https://github.com/googleapis/nodejs-storage/issues/2215))
* Do not return responsebody in delete, only raw response ([#2236](https://github.com/googleapis/nodejs-storage/issues/2236))
* Remove extraneous validation in favor of server errors ([#2237](https://github.com/googleapis/nodejs-storage/issues/2237))
* Mark bucket.setLabels and associated interfaces as deprecated ([#2214](https://github.com/googleapis/nodejs-storage/issues/2214))
* Disable source maps for smaller bundle size ([#2240](https://github.com/googleapis/nodejs-storage/issues/2240))



### Features

Expand Down
2 changes: 1 addition & 1 deletion system-test/storage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3364,7 +3364,7 @@ describe('storage', () => {
assert(err instanceof Error);
assert.strictEqual(
err.message,
`Max allowed expiration is seven days (${SEVEN_DAYS_IN_SECONDS} seconds).`
`Max allowed expiration is seven days (${SEVEN_DAYS_IN_SECONDS.toString()} seconds).`
);
return true;
}
Expand Down
2 changes: 1 addition & 1 deletion test/signer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ describe('signer', () => {
assert(err instanceof Error);
assert.strictEqual(
err.message,
`Max allowed expiration is seven days (${SEVEN_DAYS_IN_SECONDS} seconds).`
`Max allowed expiration is seven days (${SEVEN_DAYS_IN_SECONDS.toString()} seconds).`
);
return true;
}
Expand Down