Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

fix(samples): remove 'gcloud_project' environment variable #156

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

nmykhailets
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@nmykhailets nmykhailets requested a review from a team as a code owner March 10, 2022 21:39
@product-auto-label product-auto-label bot added api: retail Issues related to the googleapis/nodejs-retail API. samples Issues that are directly related to samples. labels Mar 10, 2022
@t-karasova
Copy link
Contributor

Hi @sofisl, Could you please review this PR and run the trigger the build, we need to check if the project_id can be read from retailClient.projectId?

@kweinmeister kweinmeister added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 11, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 11, 2022
@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 11, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 11, 2022
@kweinmeister kweinmeister added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 15, 2022
@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 15, 2022
@kweinmeister kweinmeister merged commit 16cefb4 into googleapis:main Mar 15, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 23, 2022
🤖 I have created a release *beep* *boop*
---


### [1.6.1](v1.6.0...v1.6.1) (2022-03-15)


### Bug Fixes

* remove gcloud_project env variable ([#156](#156)) ([16cefb4](16cefb4))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 16, 2022
🤖 I have created a release *beep* *boop*
---


### [1.6.1](googleapis/nodejs-retail@v1.6.0...v1.6.1) (2022-03-15)


### Bug Fixes

* remove gcloud_project env variable ([#156](googleapis/nodejs-retail#156)) ([16cefb4](googleapis/nodejs-retail@16cefb4))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kweinmeister pushed a commit to GoogleCloudPlatform/nodejs-docs-samples that referenced this pull request Jan 11, 2023
🤖 I have created a release *beep* *boop*
---


### [1.6.1](googleapis/nodejs-retail@v1.6.0...v1.6.1) (2022-03-15)


### Bug Fixes

* remove gcloud_project env variable ([#156](googleapis/nodejs-retail#156)) ([16cefb4](googleapis/nodejs-retail@16cefb4))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: retail Issues related to the googleapis/nodejs-retail API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants