This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
fix(samples): remove 'gcloud_project' environment variable #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: retail
Issues related to the googleapis/nodejs-retail API.
samples
Issues that are directly related to samples.
labels
Mar 10, 2022
Hi @sofisl, Could you please review this PR and run the trigger the build, we need to check if the project_id can be read from retailClient.projectId? |
kweinmeister
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Mar 11, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Mar 11, 2022
kweinmeister
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Mar 11, 2022
yoshi-kokoro
removed
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Mar 11, 2022
kweinmeister
approved these changes
Mar 11, 2022
sofisl
approved these changes
Mar 14, 2022
kweinmeister
added
owlbot:run
Add this label to trigger the Owlbot post processor.
and removed
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Mar 15, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Mar 15, 2022
kweinmeister
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Mar 15, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Mar 15, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 15, 2022
chenlei1216
approved these changes
Mar 15, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
🤖 I have created a release *beep* *boop* --- ### [1.6.1](v1.6.0...v1.6.1) (2022-03-15) ### Bug Fixes * remove gcloud_project env variable ([#156](#156)) ([16cefb4](16cefb4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release *beep* *boop* --- ### [1.6.1](googleapis/nodejs-retail@v1.6.0...v1.6.1) (2022-03-15) ### Bug Fixes * remove gcloud_project env variable ([#156](googleapis/nodejs-retail#156)) ([16cefb4](googleapis/nodejs-retail@16cefb4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kweinmeister
pushed a commit
to GoogleCloudPlatform/nodejs-docs-samples
that referenced
this pull request
Jan 11, 2023
🤖 I have created a release *beep* *boop* --- ### [1.6.1](googleapis/nodejs-retail@v1.6.0...v1.6.1) (2022-03-15) ### Bug Fixes * remove gcloud_project env variable ([#156](googleapis/nodejs-retail#156)) ([16cefb4](googleapis/nodejs-retail@16cefb4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: retail
Issues related to the googleapis/nodejs-retail API.
samples
Issues that are directly related to samples.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕