Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Subscription names are required. #61

Merged
merged 1 commit into from
Feb 9, 2018
Merged

docs: Subscription names are required. #61

merged 1 commit into from
Feb 9, 2018

Conversation

stephenplusplus
Copy link
Contributor

Fixes #59

@codecov
Copy link

codecov bot commented Feb 9, 2018 •
edited
Loading

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #61   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         842    842           
=====================================
  Hits          842    842
Impacted Files Coverage Δ
src/topic.js 100% <ø> (ø) ⬆️
src/index.js 100% <ø> (ø) ⬆️
src/subscription.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d89287c...b34972d. Read the comment docs.

@stephenplusplus stephenplusplus merged commit 4433ac8 into googleapis:master Feb 9, 2018
@stephenplusplus stephenplusplus deleted the spp--59 branch February 9, 2018 19:15
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
@greenkeeper @callmehiphop
fix(package): update google-gax to version 0.16.0 (googleapis#61)
6e680fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

@callmehiphop callmehiphop Awaiting requested review from callmehiphop

@alexander-fenster alexander-fenster Awaiting requested review from alexander-fenster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenplusplus @theacodes