Adding return of promise on subscription close when no callback is provided #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 8 8
Lines 842 845 +3
=====================================
+ Hits 842 845 +3
Continue to review full report at Codecov.
|
ctavan
reviewed
Feb 10, 2018
| }); | ||
| } else { | ||
| return flushPromise; | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
pushed a commit
to stephenplusplus/nodejs-pubsub
that referenced
this pull request
Aug 31, 2018
Update fulltext, safe search, web, and web geo samples to match canonicals
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code and test is provided.
Fixes #50