Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: refactor(subscriber): remove unneeded code & utilize typescript #388

Merged
merged 24 commits into from
Jan 14, 2019
+3,209 −3,698
Merged

BREAKING CHANGE: refactor(subscriber): remove unneeded code & utilize typescript #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
6e866cf
refactor(subscriber): remove unneeded code & utilize typescript
callmehiphop Dec 4, 2018
35ce068
refactors, cleanup and docs - oh my!
callmehiphop Dec 7, 2018
7853f9c
slight refactors
callmehiphop Jan 4, 2019
c1b55e4
lease manager unit tests
callmehiphop Jan 4, 2019
2e09223
address pr feedback
callmehiphop Jan 4, 2019
f21ecc5
message queue unit tests
callmehiphop Jan 4, 2019
92a0883
rename onFlush -> waitForFlush
callmehiphop Jan 4, 2019
32c18a8
message stream unit tests
callmehiphop Jan 7, 2019
a6cd020
misc test cleanup
callmehiphop Jan 7, 2019
fd3ec53
make highWaterMark optional
callmehiphop Jan 7, 2019
ec86df9
update license year
callmehiphop Jan 7, 2019
671beca
remove unused prop
callmehiphop Jan 7, 2019
49a3b90
unit tests for subscriber
callmehiphop Jan 7, 2019
a5a8e9c
update histogram tests
callmehiphop Jan 7, 2019
34f5afd
update subscription tests
callmehiphop Jan 7, 2019
5e12be0
push null on status just in grpc does not
callmehiphop Jan 7, 2019
5ea13a6
apparently jsdoc does not like tuples :(
callmehiphop Jan 7, 2019
10d351c
make a couple tweaks for node@6
callmehiphop Jan 7, 2019
618405c
use setReadable to intercept grpc stream
callmehiphop Jan 8, 2019
8be14a0
fix typo
callmehiphop Jan 9, 2019
a629070
expose subscriber client stub
callmehiphop Jan 14, 2019
3246dfa
refactor message-stream to use grpc client
callmehiphop Jan 14, 2019
55e6713
fix close signature
callmehiphop Jan 14, 2019
08cf878
tweak the way modAck latency is computed
callmehiphop Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,13 @@
"google-auth-library": "^2.0.0",
"google-gax": "^0.22.0",
"is": "^3.0.1",
"is-stream-ended": "^0.1.4",
"lodash.chunk": "^4.2.0",
"lodash.merge": "^4.6.0",
"lodash.snakecase": "^4.1.1",
"p-defer": "^1.0.0",
"protobufjs": "^6.8.1",
"through2": "^3.0.0",
"uuid": "^3.1.0"
"through2": "^3.0.0"
},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "^3.0.0",
Expand All @@ -70,6 +71,7 @@
"@types/extend": "^3.0.0",
"@types/is": "0.0.21",
"@types/mocha": "^5.2.5",
"@types/p-defer": "^1.0.3",
"@types/proxyquire": "^1.3.28",
"@types/sinon": "^7.0.0",
"@types/through2": "^2.0.34",
Expand All @@ -90,6 +92,7 @@
"proxyquire": "^2.0.0",
"sinon": "^7.1.1",
"source-map-support": "^0.5.9",
"typescript": "~3.2.0"
"typescript": "~3.2.0",
"uuid": "^3.1.0"
}
}
Loading