Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(subscription): add mention of auto-leasing #116

Merged
merged 2 commits into from
Apr 4, 2018
Merged

docs(subscription): add mention of auto-leasing #116

merged 2 commits into from
Apr 4, 2018

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Apr 4, 2018

Relates to #115

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@callmehiphop
Copy link
Contributor Author

/cc @toots

@codecov
Copy link

codecov bot commented Apr 4, 2018

Codecov Report

Merging #116 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #116   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         867    867           
=====================================
  Hits          867    867
Impacted Files Coverage Δ
src/subscription.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad6df3...afa7376. Read the comment docs.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@stephenplusplus stephenplusplus merged commit 79e8250 into googleapis:master Apr 4, 2018
@toots
Copy link

toots commented Apr 4, 2018

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants