Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert sinon version pin #1253

Closed
feywind opened this issue Apr 9, 2021 · 0 comments · Fixed by #1256
Closed

Revert sinon version pin #1253

feywind opened this issue Apr 9, 2021 · 0 comments · Fixed by #1256
Assignees
@feywind
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@feywind
Copy link
Collaborator

feywind commented Apr 9, 2021

When sinon gets their types updated, we should revert back to ^10.0.0 instead of 10.0.0.

#1252
@feywind feywind added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Apr 9, 2021
@feywind feywind self-assigned this Apr 9, 2021
@feywind feywind mentioned this issue Apr 14, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 14, 2021
@feywind
chore: unpin sinon again (#1256)
64da291 
fixes: #1253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feywind feywind

Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: unpin sinon again googleapis/nodejs-pubsub
1 participant
@feywind