Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle promise based functions #91

Merged
merged 4 commits into from
Mar 8, 2019
Merged

feat: handle promise based functions #91

merged 4 commits into from
Mar 8, 2019

Conversation

AVaksman
Copy link
Contributor

Paginator will now handle promise based functions.

It is a prerequisite for converting libraries to async first approach.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2019
@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@AVaksman AVaksman changed the title handle promise based originalMethod feat: handle promise based originalMethod Feb 13, 2019
@AVaksman AVaksman changed the title feat: handle promise based originalMethod feat: handle promise based functions Feb 13, 2019
@AVaksman
Copy link
Contributor Author

To keep unrelated changes separate, the failing docs test is addressed in PR #92. After #92 lands will merge master here.

@codecov
Copy link

codecov bot commented Feb 13, 2019 •
edited
Loading

Codecov Report

Merging #91 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #91   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          83     87    +4     
  Branches       10     10           
=====================================
+ Hits           83     87    +4
Impacted Files Coverage Δ
src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312f982...ed93267. Read the comment docs.

@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2019
callmehiphop
callmehiphop reviewed Feb 14, 2019
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@JustinBeckwith JustinBeckwith added needs work This is a pull request that needs a little love. and removed needs work This is a pull request that needs a little love. labels Feb 14, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 20, 2019
@AVaksman AVaksman mentioned this pull request Feb 25, 2019
Closed
2 tasks
JustinBeckwith
JustinBeckwith previously approved these changes Mar 3, 2019
View reviewed changes
@JustinBeckwith
Copy link
Contributor

@callmehiphop can you give this another look and merge if happy?

@AVaksman AVaksman mentioned this pull request Mar 5, 2019
Merged
callmehiphop
callmehiphop reviewed Mar 6, 2019
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
callmehiphop
callmehiphop reviewed Mar 6, 2019
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@JustinBeckwith JustinBeckwith dismissed their stale review March 7, 2019 22:19

leaving this one to @callmehiphop

@callmehiphop callmehiphop merged commit de1bdc0 into googleapis:master Mar 8, 2019
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callmehiphop callmehiphop callmehiphop approved these changes

@JustinBeckwith JustinBeckwith JustinBeckwith left review comments

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AVaksman @JustinBeckwith @callmehiphop @googlebot @kokoro-team @yoshi-automation