Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent permanent merging of labels #89

Merged
merged 2 commits into from
Jun 7, 2018
Merged

fix: prevent permanent merging of labels #89

merged 2 commits into from
Jun 7, 2018

Conversation

arsanjea
Copy link
Contributor

@arsanjea arsanjea commented Jun 6, 2018

Fixes the permanent merging of labels after logging a message with custom labels.

Fixes #88

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 6, 2018
@arsanjea
Copy link
Contributor Author

arsanjea commented Jun 6, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 6, 2018
@ofrobots ofrobots added semver: patch A minor bug fix or small change. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jun 6, 2018
@ofrobots
Copy link
Contributor

ofrobots commented Jun 6, 2018

Hi @arsanjea. Thank you very much for your contribution, and sorry about the bug. Thanks for fixing it.

We can go ahead and land this once we have added some tests and fix the format errors in the CI. We will take care of it, but if you want to contribute those changes, that is welcome too.

@ofrobots ofrobots self-assigned this Jun 6, 2018
@ofrobots ofrobots requested a review from DominicKramer June 7, 2018 01:01
@arsanjea
Copy link
Contributor Author

arsanjea commented Jun 7, 2018

Awesome. Great turnaround.
This package is helping me centralize all my micro services log in one place.
Happy to give back.

@JustinBeckwith JustinBeckwith merged commit 532321c into googleapis:master Jun 7, 2018
@ghost ghost removed the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. semver: patch A minor bug fix or small change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants