chore: use unique UUID per system test #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures two runs of the system tests don't conflict, which was causing problems in the past.
googlebot
added
the
cla: yes
ofrobots
suggested changes
Nov 1, 2018
system-test/logging-winston.ts
Outdated
| @@ -28,6 +31,17 @@ const logging = new Logging(); | |||
| const LoggingWinston = require('../src/index').LoggingWinston; | |||
| const LOG_NAME = 'winston_log_system_tests'; | |||
|
|
|||
| const UUID = uuid.v4(); | |||
| function message(text: string) { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
3 tasks
ofrobots
approved these changes
Nov 2, 2018
DominicKramer
commented
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The installation tests verify that Typescript
3 is required to use the this library since
google-auth-libraryrequires Typescript 3.
This ensures two runs of the system tests don't conflict, which
was causing problems in the past.