This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
docs(samples): updated samples code to use async await #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
JustinBeckwith
approved these changes
Nov 15, 2018
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
@praveenqlogic it looks like many of the sample tests are failing. Let me know when I should take another look! |
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 5 5
=====================================
Hits 5 5Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 5 5
=====================================
Hits 5 5Continue to review full report at Codecov.
|
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/google-cloud-node#2869 (it's a good idea to open an issue first for discussion)
Fixes https://github.com/googleapis/nodejs-language