Rejecting 'null' and 'undefined' as arguments for CollectionRef.doc() #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 1397 1397
=====================================
Hits 1397 1397
Continue to review full report at Codecov.
|
schmidt-sebastian
force-pushed
the
mrschmidt-undefined
branch
from
53605a8 to
826e4e8
Compare
|
@lukesneeringer @stephenplusplus Added you for final Approval. Thanks. |
|
LGTM. Side-question; can you paste the contents of the internal issue, or at least provide more context for what the bug was? |
stephenplusplus
approved these changes
Oct 11, 2017
Updated the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for Google-internal bug b/67419579:
[Node] .doc(undefined).set() does an add
We should catch "undefined" being passed and say "hey don't do that" not do an add