feat: Add OR query support
#1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
trusted-contributions-gcf
bot
added
kokoro:force-run
product-auto-label
bot
added
size: xl
gcf-owl-bot
bot
removed
the
owlbot:run
product-auto-label
bot
added
size: l
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
tom-andersen
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
MarkDuckworth
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
MarkDuckworth
added
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
MarkDuckworth
added
the
do not merge
|
@alexander-fenster, it looks like the change to support numeric enums in REST caused a regression in Firestore. Specifically the tests lists missing documents is failing. Since the test seems to be consistently failing only when using REST, I'm considering that there may be a regression. I haven't had a chance to dig in yet, but I'm tagging you now just for awareness. |
gcf-owl-bot
bot
changed the title
trusted-contributions-gcf
bot
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
kokoro:force-run
product-auto-label
bot
added
size: l
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
MarkDuckworth
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
MarkDuckworth
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
Owl bot is regenerating pull request 1803... |
docs: Improve the API documentation for the `Firestore.ListDocuments` RPC docs: Minor documentation formatting and cleanup PiperOrigin-RevId: 509631855 Source-Link: googleapis/googleapis@22bd888 Source-Link: googleapis/googleapis-gen@8b14516 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGIxNDUxNjYxOWM0OGUxZGRhYmNlYzFhZWM1NWFjMDI1NzM2NDEwMiJ9 docs: changing format of the jsdoc links PiperOrigin-RevId: 509352615 Source-Link: googleapis/googleapis@b737d30 Source-Link: googleapis/googleapis-gen@8efadf3 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGVmYWRmM2Q1ODc4MGVhMWM1NTAyNjhkNDZhM2RjNzAxYmEzN2ZjZiJ9 chore(gitignore): only ignore folders in the top level PiperOrigin-RevId: 507603203 Source-Link: googleapis/googleapis@a4f2de4 Source-Link: googleapis/googleapis-gen@dcf8821 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGNmODgyMTU0ZTdjNzEwZWNmMmExYWJjNzdiMzVjOTVmOTA2MjM3MSJ9 chore: update .gitignore to always include protos folder Use gapic-generator-typescript v3.0.0. PiperOrigin-RevId: 507004755 Source-Link: googleapis/googleapis@d784f3c Source-Link: googleapis/googleapis-gen@5e64ba8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWU2NGJhODYxNWY2NWZkZWRiMWZjZDZhYzc5MmU1ZWE2MjEwMjdlNCJ9 chore: Disable requesting numeric enums in "transport=rest" responses for nodejs-firestore PiperOrigin-RevId: 502893047 Source-Link: googleapis/googleapis@6adf7b1 Source-Link: googleapis/googleapis-gen@bf897a5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmY4OTdhNTY3ZWI4NTUyNTk5ODU0ZGUwMDMwOGIzOGIwOGZlNjJkOSJ9 feat: Added SuggestConversationSummary RPC docs: updated go library package PiperOrigin-RevId: 501862436 Source-Link: googleapis/googleapis@155e0f4 Source-Link: googleapis/googleapis-gen@3051f61 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzA1MWY2MTdhOTkxYzI3NGM4OGQyNzA2NGU4MDMwOTVlNGVmOWQzOSJ9 chore: Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java) PiperOrigin-RevId: 493113566 Source-Link: googleapis/googleapis@758f0d1 Source-Link: googleapis/googleapis-gen@78bd8f0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzhiZDhmMDVlMTI3NjM2M2ViMTRlYWU3MGU5MWZlNGJjMjA3MDNhYiJ9
gcf-owl-bot
bot
force-pushed
the
owl-bot-copy
branch
from
df4609d to
23aef42
Compare
product-auto-label
bot
added
size: xl
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
product-auto-label
bot
added
size: l
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: Improve the API documentation for the
Firestore.ListDocumentsRPCdocs: Minor documentation formatting and cleanup
PiperOrigin-RevId: 509631855
Source-Link: googleapis/googleapis@22bd888
Source-Link: https://github.com/googleapis/googleapis-gen/commit/8b14516619c48e1ddabcec1aec55ac0257364102
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGIxNDUxNjYxOWM0OGUxZGRhYmNlYzFhZWM1NWFjMDI1NzM2NDEwMiJ9
docs: changing format of the jsdoc links
PiperOrigin-RevId: 509352615
Source-Link: googleapis/googleapis@b737d30
Source-Link: https://github.com/googleapis/googleapis-gen/commit/8efadf3d58780ea1c550268d46a3dc701ba37fcf
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGVmYWRmM2Q1ODc4MGVhMWM1NTAyNjhkNDZhM2RjNzAxYmEzN2ZjZiJ9
chore(gitignore): only ignore folders in the top level
PiperOrigin-RevId: 507603203
Source-Link: googleapis/googleapis@a4f2de4
Source-Link: https://github.com/googleapis/googleapis-gen/commit/dcf882154e7c710ecf2a1abc77b35c95f9062371
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGNmODgyMTU0ZTdjNzEwZWNmMmExYWJjNzdiMzVjOTVmOTA2MjM3MSJ9
chore: update .gitignore to always include protos folder
Use gapic-generator-typescript v3.0.0.
PiperOrigin-RevId: 507004755
Source-Link: googleapis/googleapis@d784f3c
Source-Link: https://github.com/googleapis/googleapis-gen/commit/5e64ba8615f65fdedb1fcd6ac792e5ea621027e4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWU2NGJhODYxNWY2NWZkZWRiMWZjZDZhYzc5MmU1ZWE2MjEwMjdlNCJ9
chore: Disable requesting numeric enums in "transport=rest" responses for nodejs-firestore
PiperOrigin-RevId: 502893047
Source-Link: googleapis/googleapis@6adf7b1
Source-Link: https://github.com/googleapis/googleapis-gen/commit/bf897a567eb8552599854de00308b38b08fe62d9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmY4OTdhNTY3ZWI4NTUyNTk5ODU0ZGUwMDMwOGIzOGIwOGZlNjJkOSJ9
feat: Added SuggestConversationSummary RPC
docs: updated go library package
PiperOrigin-RevId: 501862436
Source-Link: googleapis/googleapis@155e0f4
Source-Link: https://github.com/googleapis/googleapis-gen/commit/3051f617a991c274c88d27064e803095e4ef9d39
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzA1MWY2MTdhOTkxYzI3NGM4OGQyNzA2NGU4MDMwOTVlNGVmOWQzOSJ9
chore: Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport
chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java)
PiperOrigin-RevId: 493113566
Source-Link: googleapis/googleapis@758f0d1
Source-Link: https://github.com/googleapis/googleapis-gen/commit/78bd8f05e1276363eb14eae70e91fe4bc20703ab
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzhiZDhmMDVlMTI3NjM2M2ViMTRlYWU3MGU5MWZlNGJjMjA3MDNhYiJ9
BEGIN_COMMIT_OVERRIDE
docs: Improve the API documentation for the
Firestore.ListDocumentsRPCdocs: Minor documentation formatting and cleanup
docs: changing format of the jsdoc links
chore: Added SuggestConversationSummary RPC protos
chore: Add OR Query RPC protos
END_COMMIT_OVERRIDE