Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add converter support #1037

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Add converter support #1037

merged 3 commits into from
Apr 23, 2020

Conversation

thebrianchen
Copy link

@thebrianchen thebrianchen commented Apr 22, 2020 •
edited
Loading

Forgot to add this earlier. I also didn't realize it would be this little work.

@thebrianchen thebrianchen self-assigned this Apr 22, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 22, 2020
schmidt-sebastian
schmidt-sebastian suggested changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit tests that uses two different Ts in the same batch.

schmidt-sebastian
schmidt-sebastian approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thebrianchen thebrianchen merged commit 06595ce into bc/bulk-master Apr 23, 2020
@thebrianchen thebrianchen deleted the bc/bulk-converter branch April 29, 2020 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@thebrianchen thebrianchen

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thebrianchen @schmidt-sebastian @googlebot