-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: update settings for Node 10 #1019
Changes from 2 commits
ead628f
0793d04
c4c1fc8
c380a8a
eb77d86
cd88990
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
**/node_modules | ||
src/**/doc/* | ||
**/.coverage | ||
build/ | ||
docs/ | ||
protos/ | ||
system-test/ | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
**/*.log | ||
**/node_modules | ||
.coverage | ||
coverage | ||
.nyc_output | ||
docs/ | ||
out/ | ||
build/ | ||
system-test/secrets.js | ||
system-test/*key.json | ||
*.lock | ||
build/ | ||
package-lock.json | ||
.vscode | ||
.DS_Store | ||
package-lock.json | ||
__pycache__ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
// Copyright 2019 Google LLC | ||
// Copyright 2020 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
|
@@ -34,18 +34,19 @@ module.exports = { | |
source: { | ||
excludePattern: '(^|\\/|\\\\)[._]', | ||
include: [ | ||
'build/src' | ||
'build/src', | ||
'protos' | ||
], | ||
includePattern: '\\.js$' | ||
}, | ||
templates: { | ||
copyright: 'Copyright 2019 Google, LLC.', | ||
copyright: 'Copyright 2020 Google LLC', | ||
includeDate: false, | ||
sourceFiles: false, | ||
systemName: '@google-cloud/firestore', | ||
systemName: 'firestore', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For this, you need to add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done (and this fixed the issue here) |
||
theme: 'lumen', | ||
default: { | ||
"outputSourceFiles": false | ||
outputSourceFiles: false | ||
} | ||
}, | ||
markdown: { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
node_modules/* | ||
samples/node_modules/* | ||
src/**/doc/* | ||
**/node_modules | ||
**/coverage | ||
test/fixtures | ||
build/ | ||
docs/ | ||
protos/ |
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tooling is gonna undo that. Any reason to explicitly ignore it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be from the tooling. I didn't make this change manually at least :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, we don't do it in other libs. Example: https://github.com/googleapis/nodejs-text-to-speech/blob/master/.eslintignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted this file and re-ran synthtool and it was recreated just like this.