-
Notifications
You must be signed in to change notification settings - Fork 271
docs: correct typo in comment #568
docs: correct typo in comment #568
Conversation
Using a sessionId as number, it causes the following error in `peg$parsetemplate`: input.charCodeAt is not a function Fixes googleapis#277
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@alexander-fenster @xiaozhenliu-gg5 👋 this seems like potentially a bug with the generated client. |
Thanks @vernig - it's indeed a bug (arguably if it's a bug in samples or in the processing code :) ) We can accept this fix, but I just sent googleapis/gax-nodejs#756 to let the processing code accept numbers (so in the next version, both |
Using a
sessionId
as number, it causes the following error inpeg$parsetemplate
:Fixes #277