Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

docs: correct typo in comment #568

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

vernig
Copy link
Contributor

@vernig vernig commented Mar 24, 2020

Using a sessionId as number, it causes the following error in peg$parsetemplate:

input.charCodeAt is not a function

Fixes #277

Using a sessionId as number, it causes the following error in
`peg$parsetemplate`:
input.charCodeAt is not a function

Fixes googleapis#277
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 24, 2020
@vernig
Copy link
Contributor Author

vernig commented Mar 24, 2020

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@vernig
Copy link
Contributor Author

vernig commented Mar 24, 2020

@googlebot I fixed it.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@gverni
Copy link
Contributor

gverni commented Mar 24, 2020

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 24, 2020
@bcoe
Copy link
Contributor

bcoe commented Mar 24, 2020

@alexander-fenster @xiaozhenliu-gg5 👋 this seems like potentially a bug with the generated client.

@alexander-fenster
Copy link
Contributor

Thanks @vernig - it's indeed a bug (arguably if it's a bug in samples or in the processing code :) ) We can accept this fix, but I just sent googleapis/gax-nodejs#756 to let the processing code accept numbers (so in the next version, both 123 and '123' will work).

@alexander-fenster alexander-fenster self-requested a review March 24, 2020 18:28
@alexander-fenster alexander-fenster added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 24, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 24, 2020
@alexander-fenster alexander-fenster merged commit c076852 into googleapis:master Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do you want me to deploy this on an AWS Lambda?
6 participants