Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

make samples tests pass #77

Merged
merged 5 commits into from
May 7, 2018
Merged

make samples tests pass #77

merged 5 commits into from
May 7, 2018

Conversation

alexander-fenster
Copy link
Contributor

This package has never had passing samples tests task. Fixing samples/package.json to run samples tests correctly, and removing a test for an obsolete sample (that still uses googleapis). Samples need to be fixed for this package, but for now, let's at least have something passing (just one remaining test is OK), to have green color in nightly testing.

@alexander-fenster alexander-fenster requested a review from jmdobry May 5, 2018 21:39
@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot googlebot removed the cla: yes This human has signed the Contributor License Agreement. label May 5, 2018
@codecov
Copy link

codecov bot commented May 5, 2018

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #77   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          19     19           
  Lines        1583   1583           
=====================================
  Hits         1583   1583

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c23f5e...79d758a. Read the comment docs.

"system-test": "ava -T 20s --verbose system-test/*.test.js",
"all-test": "npm run unit-test && npm run system-test",
"test": "repo-tools test run --cmd npm -- run all-test"
"test": "repo-tools test run --cmd ava -- -T 20s --verbose system-test/*.test.js"

This comment was marked as spam.

@@ -1,33 +0,0 @@
/**

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label May 7, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot googlebot removed the cla: yes This human has signed the Contributor License Agreement. label May 7, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 7, 2018
@alexander-fenster alexander-fenster merged commit da85e03 into master May 7, 2018
@ghost ghost removed the cla: yes This human has signed the Contributor License Agreement. label May 7, 2018
@alexander-fenster alexander-fenster deleted the samples-tests branch May 7, 2018 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants