Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Do not show sample for Google API Client library #76

Merged
merged 1 commit into from
May 3, 2018

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented May 3, 2018

Do not list this sample in the README as it is for googleapi, not
@Google-Cloud.

Keep the example source code because it is
referenced here.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

/cc @jmdobry

Keep the example source code because it is
referenced [here](https://cloud.google.com/compute/docs/tutorials/nodejs-guide).
Do not list this sample in the README as it is for googleapi, not
@Google-Cloud.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 3, 2018
@ghost ghost assigned fhinkel May 3, 2018
@fhinkel fhinkel requested a review from stephenplusplus May 3, 2018 15:20
@codecov
Copy link

codecov bot commented May 3, 2018

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #76   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          19     19           
  Lines        1583   1583           
=====================================
  Hits         1583   1583

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8070d2d...3d23dc6. Read the comment docs.

@@ -12,7 +12,6 @@ CRoed <[email protected]>
Dave Gramlich <[email protected]>
Eric Uldall <[email protected]>
F. Hinkelmann <[email protected]>
Franziska Hinkelmann <[email protected]>

This comment was marked as spam.

This comment was marked as spam.

@fhinkel fhinkel merged commit 3c23f5e into googleapis:master May 3, 2018
@ghost ghost removed the cla: yes This human has signed the Contributor License Agreement. label May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants