Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use npm root instead of cd'ing into the node_modules directory to run commands #62

Merged
merged 13 commits into from
Dec 16, 2022

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Dec 13, 2022

Attempts to change relative links to absolute links/commands so that the script works regardless of whether we are in a split or mono repo.

@sofisl sofisl requested a review from a team as a code owner December 13, 2022 22:14
@sofisl sofisl requested a review from a team December 13, 2022 22:14
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 13, 2022
@sofisl sofisl requested a review from bcoe December 13, 2022 22:20
generate-devsite-base-classes.sh Outdated Show resolved Hide resolved

echo "npx @googleapis/api-documenter@^7 yaml --input-folder=temp"
npx @googleapis/api-documenter@^7 yaml --input-folder=temp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node $(npm root)/@google-cloud/cloud-rad/node_modules/@googleapis/api-documenter/bin/api-documenter yaml --input-folder=temp

@sofisl sofisl changed the title build: fix relative links build: use npm root instead of cd'ing into the node_modules directory to run commands Dec 16, 2022
@sofisl sofisl merged commit ac72252 into main Dec 16, 2022
@sofisl sofisl deleted the fixRelativeLinks branch December 16, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants