fix: manual update for renovate-bot google cloud storage v7 (#1262)

* fix(deps): update dependency @google-cloud/storage to v7 * updating system tests to accommodate version update * reset formatting * Revert "updating system tests to accommodate version update" This reverts commit 8611846. reset formatting after system test update * updating system tests to accommodate version update --------- Co-authored-by: Renovate Bot <[email protected]>
googleapis · Aug 17, 2023 · b58fc29 · b58fc29
1 parent b70d3a4
commit b58fc29
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 9 deletions.
diff --git a/package.json b/package.json
@@ -61,7 +61,7 @@
     "uuid": "^9.0.0"
   },
   "devDependencies": {
-    "@google-cloud/storage": "^6.0.0",
+    "@google-cloud/storage": "^7.0.0",
     "@types/big.js": "^6.2.0",
     "@types/extend": "^3.0.1",
     "@types/is": "0.0.22",

diff --git a/samples/authViewTutorial.js b/samples/authViewTutorial.js
@@ -103,9 +103,8 @@ function main(
     sharedMetadata.access = sharedAccessEntries;
 
     // Make API request to update dataset metadata
-    const [updatedSharedMetadata] = await sharedDataset.setMetadata(
-      sharedMetadata
-    );
+    const [updatedSharedMetadata] =
+      await sharedDataset.setMetadata(sharedMetadata);
 
     console.log(`Dataset ${updatedSharedMetadata.id} updated.`);
     // [END bigquery_avt_shared_dataset_access]
@@ -129,9 +128,8 @@ function main(
     sourceMetadata.access = sourceAccessEntries;
 
     // Make API request to update source dataset metadata
-    const [updatedSourceMetadata] = await sourceDataset.setMetadata(
-      sourceMetadata
-    );
+    const [updatedSourceMetadata] =
+      await sourceDataset.setMetadata(sourceMetadata);
 
     console.log(`Dataset ${updatedSourceMetadata.id} updated.`);
     // [END bigquery_avt_source_dataset_access]

diff --git a/samples/package.json b/samples/package.json
@@ -17,7 +17,7 @@
   },
   "dependencies": {
     "@google-cloud/bigquery": "^7.1.1",
-    "@google-cloud/storage": "^6.0.0",
+    "@google-cloud/storage": "^7.0.0",
     "google-auth-library": "^9.0.0",
     "readline-promise": "^1.0.4",
     "yargs": "^17.0.0"

diff --git a/system-test/bigquery.ts b/system-test/bigquery.ts
@@ -1818,7 +1818,15 @@ describe('BigQuery', () => {
     });
 
     const deleteBucketPromises = buckets
-      .filter(bucket => isResourceStale(bucket.metadata.timeCreated))
+      .filter(bucket => {
+        try {
+          if (typeof bucket.metadata.timeCreated === 'string') {
+            isResourceStale(bucket.metadata.timeCreated);
+          }
+        } catch {
+          throw Error('timeCreated on type BucketMetadata cannot be undefined');
+        }
+      })
       .map(async b => {
         const [files] = await b.getFiles();
         await Promise.all(files.map(f => f.delete()));