added code review updates

googleapis · Nov 9, 2018 · 2d4c9a1 · 2d4c9a1
1 parent 2f9a2b7
commit 2d4c9a1
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 30 deletions.
diff --git a/samples/package.json b/samples/package.json
@@ -19,6 +19,7 @@
   },
   "devDependencies": {
     "@google-cloud/nodejs-repo-tools": "^2.3.0",
+    "mocha": "^5.0.0",
     "nyc": "^13.0.0",
     "proxyquire": "^2.0.0",
     "sinon": "^7.0.0",

diff --git a/samples/system-test/quickstart.test.js b/samples/system-test/quickstart.test.js
@@ -38,39 +38,29 @@ describe(`Quickstart`, () => {
   });
 
   it(`quickstart should create a dataset`, async () => {
-    await new Promise((resolve, reject) => {
-      const bigqueryMock = {
-        createDataset: async _datasetId => {
-          try {
-            assert.strictEqual(_datasetId, expectedDatasetId);
+    const bigqueryMock = {
+      createDataset: async _datasetId => {
+        assert.strictEqual(_datasetId, expectedDatasetId);
 
-            const [dataset] = await bigquery.createDataset(datasetId);
-            assert.notStrictEqual(dataset, undefined);
+        const [dataset] = await bigquery.createDataset(datasetId);
+        assert.notStrictEqual(dataset, undefined);
 
-            setTimeout(() => {
-              try {
-                assert.ok(console.log.calledOnce);
-                assert.deepStrictEqual(console.log.firstCall.args, [
-                  `Dataset ${dataset.id} created.`,
-                ]);
-                resolve();
-              } catch (err) {
-                reject(err);
-              }
-            }, 200);
+        await new Promise(
+          setTimeout(() => {
+            assert.ok(console.log.calledOnce);
+            assert.deepStrictEqual(console.log.firstCall.args, [
+              `Dataset ${dataset.id} created.`,
+            ]);
+          }, 200)
+        );
+        return [dataset];
+      },
+    };
 
-            return [dataset];
-          } catch (err) {
-            reject(err);
-          }
-        },
-      };
-
-      proxyquire(`../quickstart`, {
-        '@google-cloud/bigquery': {
-          BigQuery: sinon.stub().returns(bigqueryMock),
-        },
-      });
+    proxyquire(`../quickstart`, {
+      '@google-cloud/bigquery': {
+        BigQuery: sinon.stub().returns(bigqueryMock),
+      },
     });
   });
 });