fix: headers were incorrectly set to application/x-www-form-urlencoded

This is a long standing bug that prevents us from setting content-type in gaxios. Refs: googleapis/google-api-nodejs-client#2003 Refs: googleapis/gaxios#263
googleapis · Feb 26, 2021 · 95ff1e5 · 95ff1e5
1 parent 68c76c2
commit 95ff1e5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -327,7 +327,7 @@ export class GoogleToken {
           grant_type: 'urn:ietf:params:oauth:grant-type:jwt-bearer',
           assertion: signedJWT,
         },
-        headers: {'Content-Type': 'application/x-www-form-urlencoded'},
+        headers: {'Content-Type': 'application/json'},
         responseType: 'json',
       });
       this.rawToken = r.data;

diff --git a/test/index.ts b/test/index.ts
@@ -610,16 +610,14 @@ describe('.getToken()', () => {
 });
 
 function createGetTokenMock(code = 200, body?: {}) {
-  return nock(GOOGLE_TOKEN_URLS[0])
+  return nock(GOOGLE_TOKEN_URLS[0], {
+    reqheaders: {'Content-Type': 'application/json'},
+  })
     .replyContentLength()
-    .post(
-      GOOGLE_TOKEN_URLS[1],
-      {
-        grant_type: 'urn:ietf:params:oauth:grant-type:jwt-bearer',
-        assertion: /.?/,
-      },
-      {reqheaders: {'Content-Type': 'application/x-www-form-urlencoded'}}
-    )
+    .post(GOOGLE_TOKEN_URLS[1], {
+      grant_type: 'urn:ietf:params:oauth:grant-type:jwt-bearer',
+      assertion: /.?/,
+    })
     .reply(code, body);
 }