Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add GcpBearerAuthCredentialProvider for Schema Registry Clients #24

Merged
merged 1 commit into from
Nov 12, 2024
Merged

feature: Add GcpBearerAuthCredentialProvider for Schema Registry Clients #24

merged 1 commit into from
Nov 12, 2024

Conversation

Dippatel98
Copy link
Contributor

@Dippatel98 Dippatel98 commented Nov 1, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Follow the Samples Style Guide
  • Ensure the tests and linter pass
  • Communicate test infrastructure changes, i.e. API enablement, secrets
  • Appropriate docs were updated (if necessary)

🛠️ Fixes #25

@Dippatel98 Dippatel98 requested a review from a team as a code owner November 1, 2024 16:59
@Dippatel98 Dippatel98 marked this pull request as draft November 1, 2024 17:41
@Dippatel98 Dippatel98 marked this pull request as ready for review November 1, 2024 19:12
@Dippatel98
Copy link
Contributor Author

r: @acocuzzo

acocuzzo
acocuzzo approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@acocuzzo acocuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small nit

...a-auth/src/main/java/com/google/cloud/hosted/kafka/auth/GcpBearerAuthCredentialProvider.java Outdated Show resolved Hide resolved
@acocuzzo
Copy link
Collaborator

@Dippatel98 to fix conventional commits you can name the PR something like "fix: xxxx" or "feature: xxxx"
and please create an issue + add to description

@Dippatel98 Dippatel98 changed the title Adding GcpBearerAuthCredentialProvider for Schema Registry Clients feature: Add GcpBearerAuthCredentialProvider for Schema Registry Clients Nov 11, 2024
@acocuzzo acocuzzo merged commit 7c629d4 into googleapis:main Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acocuzzo acocuzzo acocuzzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add BearerAuthCredentialProvider for Schema Registry Clients
2 participants
@Dippatel98 @acocuzzo