Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update README.md to reflect GKE WIF limitation #23

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

amfisher-404
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Follow the Samples Style Guide
  • Ensure the tests and linter pass
  • Communicate test infrastructure changes, i.e. API enablement, secrets
  • Appropriate docs were updated (if necessary)

🛠️ Fixes #<issue_number_goes_here>

@amfisher-404 amfisher-404 requested a review from a team as a code owner October 21, 2024 20:04
@amfisher-404 amfisher-404 changed the title Update README.md to reflect GKE WIF limitation doc: Update README.md to reflect GKE WIF limitation Oct 21, 2024
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@amfisher-404 amfisher-404 marked this pull request as draft October 21, 2024 20:24
@amfisher-404 amfisher-404 marked this pull request as ready for review November 5, 2024 18:28
@amfisher-404 amfisher-404 changed the title doc: Update README.md to reflect GKE WIF limitation docs: Update README.md to reflect GKE WIF limitation Nov 5, 2024
@davidtorres davidtorres merged commit bbda273 into googleapis:main Nov 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants