Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: instructions for non-Java clients #16

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

davidtorres
Copy link
Collaborator

Expanding the instructions for non-Java client libraries.

Expanding the instructions for non-Java client libraries.
@davidtorres davidtorres requested a review from a team as a code owner August 16, 2024 17:52
README.md Outdated Show resolved Hide resolved
README.md Outdated
```

3. Configure your Kafka client, including the following authentication properties.
3. Configure your Kafka client, including the following client authentication properties.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 3. with 2.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the changes were not pushed yet?

Copy link
Collaborator

@acocuzzo acocuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with nits.

Expanding the instructions for non-Java client libraries.
Expanding the instructions for non-Java client libraries.
Expanding the instructions for non-Java client libraries.
@davidtorres davidtorres merged commit 52ff062 into main Aug 22, 2024
4 checks passed
@davidtorres davidtorres deleted the non-java-client-instructions branch August 22, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants