Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

samples: remove migrated samples #1084

Merged
merged 3 commits into from
Nov 18, 2022
Merged

samples: remove migrated samples #1084

merged 3 commits into from
Nov 18, 2022

Conversation

anguillanneuf
Copy link
Contributor

A follow-up of GoogleCloudPlatform/java-docs-samples#7425.

Docs samples links have been updated in cl/489286295.

Part of a fixit.

@anguillanneuf anguillanneuf requested a review from a team as a code owner November 17, 2022 23:11
@snippet-bot
Copy link

snippet-bot bot commented Nov 17, 2022 •
edited
Loading

Here is the summary of possible violations 😱

There is a possible violation for removing region tag in use.

The end of the violation section. All the stuff below is FYI purposes only.

You are about to delete the following sample browser pages.

Here is the summary of changes.

You are about to delete 43 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: videointelligence Issues related to the googleapis/java-video-intelligence API. samples Issues that are directly related to samples. labels Nov 17, 2022
@anguillanneuf anguillanneuf added snippet-bot:force-run Force snippet-bot runs its logic and removed snippet-bot:force-run Force snippet-bot runs its logic labels Nov 18, 2022
@anguillanneuf
Copy link
Contributor Author

There is a possible violation for removing region tag in use.
samples/snippets/src/main/java/video/DetectFaces.java:19, tag video_detect_faces(usage: page 1).

This has been addressed in cl/489487587 and the correct sample link now shows up in https://cloud.google.com/video-intelligence/docs/face-detection. Snippet bot check is delayed. Okay to merge.

@anguillanneuf anguillanneuf added the snippet-bot:force-run Force snippet-bot runs its logic label Nov 18, 2022
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Nov 18, 2022
@anguillanneuf anguillanneuf added snippet-bot:no-prefix-req Instruct snippet-bot to ignore prefix requirement and removed snippet-bot:no-prefix-req Instruct snippet-bot to ignore prefix requirement labels Nov 18, 2022
@anguillanneuf anguillanneuf merged commit fe1a6c4 into main Nov 18, 2022
@anguillanneuf anguillanneuf deleted the sample-migration branch November 18, 2022 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees

@Shabirmean Shabirmean

Labels
api: videointelligence Issues related to the googleapis/java-video-intelligence API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anguillanneuf @blakeli0 @Shabirmean