Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve 503 handling for json resumable queries #2977

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sfc-gh-mwnukowski
Copy link

@sfc-gh-mwnukowski sfc-gh-mwnukowski commented Mar 7, 2025

This is exactly the same as #2289 - seem like a duplicated code that diverged.

Fixes a rare 503 handling issue

...
caused by NullPointerException: Cannot invoke "String.toLowerCase(java.util.Locale)" because the return value of "com.google.api.client.http.HttpResponseException.getContent()" is null
...
com.google.cloud.storage.JsonResumableSessionQueryTask.call(JsonResumableSessionQueryTask.java:117)
com.google.cloud.storage.JsonResumableSession.query(JsonResumableSession.java:57)
caused by StorageException: Unknown Error
	|> PUT https://storage.googleapis.com/upload/storage/v1/b/gcpeuropewest4-gcpeuropewest3-e942/o?name=<...>
	|> content-range: bytes */*
	|> x-goog-gcs-idempotency-token: <...>
	|  
	|< HTTP/1.1 503 Service Unavailable
	|< content-length: 0
	|< content-type: text/plain; charset=utf-8
	|< x-guploader-uploadid: <...>
	|  

cc @BenWhitehead

@sfc-gh-mwnukowski sfc-gh-mwnukowski requested a review from a team as a code owner March 7, 2025 02:10
Copy link

google-cla bot commented Mar 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage API. labels Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant