Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Instrument Reader and Writer methods #2829

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

sydney-munro
Copy link
Collaborator

This PR also adds back testbench support that was previously removed for local development.

@sydney-munro sydney-munro requested a review from a team as a code owner November 27, 2024 18:59
Copy link

conventional-commit-lint-gcf bot commented Nov 27, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Nov 27, 2024
@@ -16,6 +16,7 @@

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is adding back code that was removed for local development.

@sydney-munro sydney-munro merged commit 125fc4e into otel-v1-branch Dec 6, 2024
16 checks passed
@sydney-munro sydney-munro deleted the reader-otel branch December 6, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants