feat: Instrument ReadAllBytes and CreateFrom in gRPC #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
| @@ -372,37 +388,46 @@ public Blob createFrom(BlobInfo blobInfo, InputStream content, BlobWriteOption.. | |||
| public Blob createFrom( | |||
| BlobInfo blobInfo, InputStream in, int bufferSize, BlobWriteOption... options) | |||
| throws IOException { | |||
| requireNonNull(blobInfo, "blobInfo must be non null"); | |||
| OpenTelemetryTraceUtil.Span otelSpan = | |||
| openTelemetryTraceUtil.startSpan("createFrom", this.getClass().getName()); | |||
There was a problem hiding this comment.
since createFrom has a few different signatures, does which signature we're working with need to be captured in the span?
There was a problem hiding this comment.
we are only concerned with the method not the parameters.
JesseLovelace
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.