-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create(Blob) instrumentation #2792
Conversation
8cc3a2b
to
3856854
Compare
9efdd37
to
8fe835b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still reviewing adding one question; I see it's WIP; are you ready for review?
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageImpl.java
Show resolved
Hide resolved
not yet just testing some stuff out as the testbench integration is a pain to sort out locally. |
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageImpl.java
Show resolved
Hide resolved
023a996
to
3543adf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have couple of comments; but LGTM, approving; feel free to merge after addressing them.
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageImpl.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/test/java/com/google/cloud/storage/ITGrpcOpenTelemetryTest.java
Outdated
Show resolved
Hide resolved
...e/src/test/java/com/google/cloud/storage/ParallelCompositeUploadWritableByteChannelTest.java
Outdated
Show resolved
Hide resolved
cc8dc4b
to
8e2dc67
Compare
8e2dc67
to
b4d2591
Compare
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.