Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update gRPC ReadObject retry to avoid double retry #2765

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

BenWhitehead
Copy link
Collaborator

Prevent adding an unavailable error to the queue if the retrying loop is still active.

Also, cleanup unused retry config for gRPC ReadObject.

Prevent adding an unavailable error to the queue if the retrying loop is still active.

Also, cleanup unused retry config for gRPC ReadObject.
@BenWhitehead BenWhitehead requested a review from a team as a code owner October 9, 2024 17:26
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. labels Oct 9, 2024
@BenWhitehead BenWhitehead merged commit 1fc57b9 into main Oct 10, 2024
21 checks passed
@BenWhitehead BenWhitehead deleted the fix-grpc-read-object-stream-end branch October 10, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants