Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update GrpcStorageOptions to attempt direct path by default #2715

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

BenWhitehead
Copy link
Collaborator

No description provided.

Update our tests to not attempt direct path, as we do not always run in gce.
@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Sep 19, 2024
@BenWhitehead BenWhitehead requested a review from a team as a code owner September 19, 2024 20:36
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage API. labels Sep 19, 2024
Copy link
Collaborator

@sydney-munro sydney-munro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 20, 2024
@BenWhitehead
Copy link
Collaborator Author

Issues created to investigate native image failures for xds #2716

@BenWhitehead BenWhitehead merged commit 9de9a92 into main Sep 20, 2024
20 of 21 checks passed
@BenWhitehead BenWhitehead deleted the grpc-dp-default branch September 20, 2024 20:01
lqiu96 pushed a commit that referenced this pull request Sep 23, 2024
Update our tests to not attempt direct path, as we do not always run in gce.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants