Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add branch protection rules to feat/transfer-manager #2054

Merged
merged 2 commits into from
Jun 7, 2023
Merged

chore: Add branch protection rules to feat/transfer-manager #2054

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19fb026
chore: Add branch protection rules to feat/transfer-manager
sydney-munro Jun 7, 2023
215d73e
Update .github/sync-repo-settings.yaml
sydney-munro Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/sync-repo-settings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,22 @@ branchProtectionRules:
- cla/google
- 'Kokoro - Test: Java GraalVM Native Image'
- 'Kokoro - Test: Java 17 GraalVM Native Image'
- pattern: feat/transfer-manager
isAdminEnforced: true
requiredApprovingReviewCount: 1
requiresCodeOwnerReviews: true
requiresStrictStatusChecks: false
requiredStatusCheckContexts:
- dependencies (8)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think spacing before - has any effect on the parser reading but could you add padding similar to patterns above?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - didn't realize the spacing was misaligned!

- dependencies (11)
- lint
- clirr
- units (8)
- units (11)
- 'Kokoro - Test: Integration'
- cla/google
- 'Kokoro - Test: Java GraalVM Native Image'
- 'Kokoro - Test: Java 17 GraalVM Native Image'
sydney-munro marked this conversation as resolved.
Show resolved Hide resolved
permissionRules:
- team: yoshi-admins
permission: admin
Expand Down