fix: include invocation-id for resumable PUTs #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change BlobWriteChannel to us Retrying.run so it will receive an invocation id
product-auto-label
bot
added
size: s
frankyn
reviewed
Jun 5, 2023
| @@ -186,7 +186,9 @@ private static StorageException unrecoverableState( | |||
| @Override | |||
| protected void flushBuffer(final int length, final boolean lastChunk) { | |||
| try { | |||
| runWithRetries( | |||
| Retrying.run( | |||
There was a problem hiding this comment.
Am IIUC runWithRetries did not use InvocationId support and using Retrying.run() will address that?
frankyn
approved these changes
Jun 5, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
🤖 I have created a release *beep* *boop* --- ## [2.22.4](https://togithub.com/googleapis/java-storage/compare/v2.22.3...v2.22.4) (2023-06-07) ### Bug Fixes * Include invocation-id for resumable PUTs ([#2047](https://togithub.com/googleapis/java-storage/issues/2047)) ([a590ae3](https://togithub.com/googleapis/java-storage/commit/a590ae3856fe8cccde17def5ca6bef8cfeed5073)) ### Documentation * Add documentation about quantum write alignment, use of ObjectChecksums, Bucket.name format, and Object.delete_time ([#2032](https://togithub.com/googleapis/java-storage/issues/2032)) ([c39ec13](https://togithub.com/googleapis/java-storage/commit/c39ec13469342ed947b12dd7ab3d301ca1d4d01b)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.11.0 ([#2050](https://togithub.com/googleapis/java-storage/issues/2050)) ([88fffbd](https://togithub.com/googleapis/java-storage/commit/88fffbd56746ff212441fafd1e213177feac0cac)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change BlobWriteChannel to us Retrying.run so it will receive an invocation id