Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrading protobuf to 23.2 for code generation #2032

Merged
merged 7 commits into from
Jun 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,20 +50,20 @@ If you are using Maven without the BOM, add this to your dependencies:
If you are using Gradle 5.x or later, add this to your dependencies:

```Groovy
implementation platform('com.google.cloud:libraries-bom:26.15.0')
implementation platform('com.google.cloud:libraries-bom:26.16.0')

implementation 'com.google.cloud:google-cloud-storage'
```
If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-storage:2.22.2'
implementation 'com.google.cloud:google-cloud-storage:2.22.3'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-storage" % "2.22.2"
libraryDependencies += "com.google.cloud" % "google-cloud-storage" % "2.22.3"
```
<!-- {x-version-update-end} -->

Expand Down Expand Up @@ -426,7 +426,7 @@ Java is a registered trademark of Oracle and/or its affiliates.
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-storage/java11.html
[stability-image]: https://img.shields.io/badge/stability-stable-green
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-storage.svg
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-storage/2.22.2
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-storage/2.22.3
[authentication]: https://github.com/googleapis/google-cloud-java#authentication
[auth-scopes]: https://developers.google.com/identity/protocols/oauth2/scopes
[predefined-iam-roles]: https://cloud.google.com/iam/docs/understanding-roles#predefined_roles
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -426,10 +426,10 @@ public final UnaryCallable<GetBucketRequest, Bucket> getBucketCallable() {
*
* @param parent Required. The project to which this bucket will belong.
* @param bucket Properties of the new bucket being inserted. The name of the bucket is specified
* in the `bucket_id` field. Populating `bucket.name` field will result in an error. The
* project of the bucket must be specified in the `bucket.project` field. This field must be
* in `projects/{projectIdentifier}` format, {projectIdentifier} can be the project ID or
* project number. The `parent` field must be either empty or `projects/_`.
* in the `bucket_id` field. Populating `bucket.name` field will be ignored. The project of
* the bucket must be specified in the `bucket.project` field. This field must be in
* `projects/{projectIdentifier}` format, {projectIdentifier} can be the project ID or project
* number. The `parent` field must be either empty or `projects/_`.
* @param bucketId Required. The ID to use for this bucket, which will become the final component
* of the bucket's resource name. For example, the value `foo` might result in a bucket with
* the name `projects/123456/buckets/foo`.
Expand Down Expand Up @@ -467,10 +467,10 @@ public final Bucket createBucket(ProjectName parent, Bucket bucket, String bucke
*
* @param parent Required. The project to which this bucket will belong.
* @param bucket Properties of the new bucket being inserted. The name of the bucket is specified
* in the `bucket_id` field. Populating `bucket.name` field will result in an error. The
* project of the bucket must be specified in the `bucket.project` field. This field must be
* in `projects/{projectIdentifier}` format, {projectIdentifier} can be the project ID or
* project number. The `parent` field must be either empty or `projects/_`.
* in the `bucket_id` field. Populating `bucket.name` field will be ignored. The project of
* the bucket must be specified in the `bucket.project` field. This field must be in
* `projects/{projectIdentifier}` format, {projectIdentifier} can be the project ID or project
* number. The `parent` field must be either empty or `projects/_`.
* @param bucketId Required. The ID to use for this bucket, which will become the final component
* of the bucket's resource name. For example, the value `foo` might result in a bucket with
* the name `projects/123456/buckets/foo`.
Expand Down Expand Up @@ -2674,7 +2674,9 @@ public final UnaryCallable<UpdateObjectRequest, Object> updateObjectCallable() {
* were already persisted (without checking that it matches the previously written data), and
* write only the data starting from the persisted offset. Even though the data isn't written, it
* may still incur a performance cost over resuming at the correct write offset. This behavior can
* make client-side handling simpler in some cases.
* make client-side handling simpler in some cases. - Clients must only send data that is a
* multiple of 256 KiB per message, unless the object is being finished with `finish_write` set to
* `true`.
*
* <p>The service will not view the object as complete until the client has sent a
* `WriteObjectRequest` with `finish_write` set to `true`. Sending any requests on a stream after
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1713,6 +1713,8 @@ default void updateObject(
* persisted offset. Even though the data isn't written, it may still
* incur a performance cost over resuming at the correct write offset.
* This behavior can make client-side handling simpler in some cases.
* - Clients must only send data that is a multiple of 256 KiB per message,
* unless the object is being finished with `finish_write` set to `true`.
* The service will not view the object as complete until the client has
* sent a `WriteObjectRequest` with `finish_write` set to `true`. Sending any
* requests on a stream after sending a request with `finish_write` set to
Expand Down Expand Up @@ -2320,6 +2322,8 @@ public void updateObject(
* persisted offset. Even though the data isn't written, it may still
* incur a performance cost over resuming at the correct write offset.
* This behavior can make client-side handling simpler in some cases.
* - Clients must only send data that is a multiple of 256 KiB per message,
* unless the object is being finished with `finish_write` set to `true`.
* The service will not view the object as complete until the client has
* sent a `WriteObjectRequest` with `finish_write` set to `true`. Sending any
* requests on a stream after sending a request with `finish_write` set to
Expand Down
Loading