Skip to content

Commit

Permalink
chore: update BlobWriteSessionConfig to implement Serializable (#2147)
Browse files Browse the repository at this point in the history
BlobWriteSessionConfig needs to implement Serializable because it plugs into StorageOptions which is Serializable.

Not sure, how the SerializationTest was passing when the PR was posted and now fails on main.
  • Loading branch information
BenWhitehead authored Jul 28, 2023
1 parent 0b52f90 commit df9a154
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import com.google.cloud.storage.UnifiedOpts.Opts;
import com.google.storage.v2.WriteObjectResponse;
import java.io.IOException;
import java.io.Serializable;
import java.time.Clock;

/**
Expand All @@ -39,7 +40,7 @@
*/
// When we have java modules, actually seal this to internal extension only
@InternalApi
public abstract class BlobWriteSessionConfig {
public abstract class BlobWriteSessionConfig implements Serializable {

@InternalApi
BlobWriteSessionConfig() {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
@Immutable
@BetaApi
public final class DefaultBlobWriteSessionConfig extends BlobWriteSessionConfig {
private static final long serialVersionUID = -6873740918589930633L;

private final int chunkSize;

Expand Down

0 comments on commit df9a154

Please sign in to comment.