test: disable grpc client side metrics for tests (#2683)

Our test suite creates thousands of instances of storage clients, the vast majority against test bench and non-directpath. Explicitly disable grpc client metrics to avoid the bootstrapping overhead and permission failures that happen.
googleapis · Aug 23, 2024 · 53fbba7 · 53fbba7
1 parent 742514b
commit 53fbba7
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 2 deletions.
diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/FakeServer.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/FakeServer.java
@@ -60,6 +60,7 @@ static FakeServer of(StorageGrpc.StorageImplBase service) throws IOException {
             .setProjectId("test-proj")
             .setCredentials(NoCredentials.getInstance())
             .setGrpcInterceptorProvider(GrpcPlainRequestLoggingInterceptor.getInterceptorProvider())
+            .setEnableGrpcClientMetrics(false)
             .build();
     return new FakeServer(server, grpcStorageOptions);
   }

diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/ITStorageLifecycleTest.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/ITStorageLifecycleTest.java
@@ -50,6 +50,7 @@ public void grpc() throws Exception {
             .setHost(testBench.getGRPCBaseUri())
             .setCredentials(NoCredentials.getInstance())
             .setProjectId("test-project-id")
+            .setEnableGrpcClientMetrics(false)
             .build();
 
     Storage service1 = options.getService();

diff --git a/...ud-storage/src/test/java/com/google/cloud/storage/conformance/retry/RetryTestFixture.java b/...ud-storage/src/test/java/com/google/cloud/storage/conformance/retry/RetryTestFixture.java
@@ -157,7 +157,10 @@ private Storage newStorage(boolean forTest) {
           builder = StorageOptions.http().setHost(testBench.getBaseUri());
           break;
         case GRPC:
-          builder = StorageOptions.grpc().setHost(testBench.getGRPCBaseUri());
+          builder =
+              StorageOptions.grpc()
+                  .setHost(testBench.getGRPCBaseUri())
+                  .setEnableGrpcClientMetrics(false);
           break;
         default:
           throw new IllegalStateException(

diff --git a/...e-cloud-storage/src/test/java/com/google/cloud/storage/it/ITGrpcIdempotencyTokenTest.java b/...e-cloud-storage/src/test/java/com/google/cloud/storage/it/ITGrpcIdempotencyTokenTest.java
@@ -68,6 +68,7 @@ public void setUp() throws Exception {
     storage =
         StorageOptions.grpc()
             .setGrpcInterceptorProvider(() -> ImmutableList.of(requestAuditing))
+            .setEnableGrpcClientMetrics(false)
             .build()
             .getService();
   }

diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITStorageOptionsTest.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITStorageOptionsTest.java
@@ -64,7 +64,11 @@ public void clientShouldConstructCleanly_http() throws Exception {
   @Test
   public void clientShouldConstructCleanly_grpc() throws Exception {
     StorageOptions options =
-        StorageOptions.grpc().setCredentials(credentials).setAttemptDirectPath(false).build();
+        StorageOptions.grpc()
+            .setCredentials(credentials)
+            .setAttemptDirectPath(false)
+            .setEnableGrpcClientMetrics(false)
+            .build();
     doTest(options);
   }
 

diff --git a/...d-storage/src/test/java/com/google/cloud/storage/it/runner/registry/BackendResources.java b/...d-storage/src/test/java/com/google/cloud/storage/it/runner/registry/BackendResources.java
@@ -117,6 +117,7 @@ static BackendResources of(Backend backend) {
                   optionsBuilder
                       .setGrpcInterceptorProvider(
                           GrpcPlainRequestLoggingInterceptor.getInterceptorProvider())
+                      .setEnableGrpcClientMetrics(false)
                       .build();
               return new StorageInstance(built, protectedBucketNames);
             });