Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent NPE when bucket doesn't exist #857 #860

Merged
merged 6 commits into from
Mar 17, 2022
Merged

fix: Prevent NPE when bucket doesn't exist #857 #860

merged 6 commits into from
Mar 17, 2022

Conversation

lbergelson
Copy link
Contributor

@lbergelson lbergelson commented Mar 15, 2022 •
edited
Loading

Fixes a NullPointerException when creating a Path object with a bucket
that doesn't exist. This only occurred when autoDetectRequesterPays = true.

Refs: #857

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #857☕️

If you write sample code, please follow the samples format.

@lbergelson lbergelson requested a review from a team as a code owner March 15, 2022 19:57
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage-nio API. label Mar 15, 2022
@lbergelson lbergelson changed the title fix: Prevent NPE when bucket doesn't exit #857 fix: Prevent NPE when bucket doesn't exist #857 Mar 15, 2022
@lbergelson
fix: Prevent NPE when bucket doesn't exit googleapis#857
c9d6353 
Fixes a NullPointerException when creating a Path object with a bucket
that doesn't exist. This only occurred when autoDetectRequesterPays = true.

Refs: googleapis#857
@sydney-munro sydney-munro added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 16, 2022
@sydney-munro sydney-munro added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 16, 2022
@sydney-munro sydney-munro added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 16, 2022
@sydney-munro sydney-munro added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 16, 2022
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2022
@sydney-munro sydney-munro added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 69cab9e into googleapis:main Mar 17, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 17, 2022
@release-please release-please bot mentioned this pull request Mar 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-munro sydney-munro sydney-munro approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage-nio API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE when creating a Path with a bucket that doesn't exist.
3 participants
@lbergelson @sydney-munro @yoshi-kokoro