Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): support multiplexed session for Partitioned operations #3231

Merged
merged 20 commits into from
Dec 9, 2024

Conversation

pratickchokhani
Copy link
Contributor

@pratickchokhani pratickchokhani commented Aug 1, 2024

With multiplexed sessions, the client optimises and runs multiple applicable requests concurrently on a single session. A single multiplexed session is sufficient to handle all concurrent partitioned read, query and dml operations.

This can be enabled through an environment variable GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_PARTITIONED_OPS.

@pratickchokhani pratickchokhani requested a review from a team as a code owner August 1, 2024 10:35
@pratickchokhani pratickchokhani marked this pull request as draft August 1, 2024 10:35
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Aug 1, 2024
@pratickchokhani pratickchokhani changed the title feat(spanner): support multiplexed session for Partitioned read or query feat(spanner): support multiplexed session for Partitioned operations Aug 2, 2024
Copy link

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Nov 25, 2024
@pratickchokhani pratickchokhani marked this pull request as ready for review November 25, 2024 14:52
@pratickchokhani pratickchokhani requested a review from a team as a code owner November 25, 2024 14:52
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Nov 27, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Dec 9, 2024
@pratickchokhani pratickchokhani merged commit 4501a3e into googleapis:main Dec 9, 2024
32 checks passed
sagnghos pushed a commit to sagnghos/java-spanner that referenced this pull request Dec 11, 2024
…googleapis#3231)

* feat(spanner): support multiplexed session for Partitioned read or query.

* chore(spanner): lint fixes

* feat(spanner): support multiplexed session for Partitioned DML operations.

* lint(spanner): javadoc fixes.

* feat(spanner): Updated unit tests of Partitioned operations for Multiplexed Session.

* feat(spanner): Updated unit tests of Partitioned operations for Multiplexed Session.

* lint(spanner): Apply suggestions from code review

Co-authored-by: Knut Olav Løite <[email protected]>

* lint(spanner): Apply suggestions from code review

Co-authored-by: Knut Olav Løite <[email protected]>

* feat(spanner): Modified BatchClientImpl to store multiplexed session and create fresh session after expiration date.

* feat(spanner): Removed env variable for Partitioned Ops ensuring that Multiplexed Session for Partitioned Ops is not available to customers.

* lint(spanner): Removed unused variables.

---------

Co-authored-by: Knut Olav Løite <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants