Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sample: add support for Directed Read options #2394

Merged
merged 11 commits into from
Jan 19, 2024
Merged

sample: add support for Directed Read options #2394

merged 11 commits into from
Jan 19, 2024

Conversation

rajatbhatta
Copy link
Contributor

@rajatbhatta rajatbhatta commented Apr 20, 2023 •
edited by harshachinta
Loading

This PR adds samples for Directed Reads.
The implementation for Directed Reads is in #2766

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Apr 20, 2023
@rajatbhatta rajatbhatta marked this pull request as ready for review April 21, 2023 10:20
@rajatbhatta rajatbhatta requested a review from a team as a code owner April 21, 2023 10:20
@snippet-bot
Copy link

snippet-bot bot commented Apr 21, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@rajatbhatta @olavloite
fix nit
8b3fadd 
Co-authored-by: Knut Olav Løite <[email protected]>
@harshachinta harshachinta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2024
@rajatbhatta rajatbhatta requested a review from a team as a code owner January 18, 2024 16:58
@harshachinta harshachinta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
olavloite
olavloite approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of suggestions for additional comments.

samples/snippets/src/main/java/com/example/spanner/DirectedReadSample.java Outdated Show resolved Hide resolved
samples/snippets/src/main/java/com/example/spanner/DirectedReadSample.java Outdated Show resolved Hide resolved
samples/snippets/src/main/java/com/example/spanner/DirectedReadSample.java Outdated Show resolved Hide resolved
samples/snippets/src/main/java/com/example/spanner/DirectedReadSample.java Show resolved Hide resolved
@harshachinta harshachinta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
@harshachinta harshachinta merged commit 6b9513f into googleapis:main Jan 19, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshachinta harshachinta harshachinta left review comments

@olavloite olavloite olavloite approved these changes

@arpan14 arpan14 Awaiting requested review from arpan14

@asthamohta asthamohta Awaiting requested review from asthamohta

Assignees

@kweinmeister kweinmeister

Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajatbhatta @olavloite @harshachinta @kweinmeister