Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update samples/snippets pom.xml configuration to avoid fat jar #2100

Merged
merged 3 commits into from
Dec 5, 2022
Merged

fix: update samples/snippets pom.xml configuration to avoid fat jar #2100

merged 3 commits into from
Dec 5, 2022

Conversation

harshachinta
Copy link
Contributor

@harshachinta harshachinta commented Oct 7, 2022 •
edited
Loading

This fix updates the build configuration of samples/snippets pom.xml by not creating a fat jar to avoid unexpected issues and code breaks in different environments and systems.

Existing Configuration:

  1. Creates a jar file spanner-google-cloud-samples-jar-with-dependencies.jar (fat jar) under target folder.
  2. Samples are executed by running the following command.
java -jar target/spanner-google-cloud-samples-jar-with-dependencies.jar \
    writeusingdml test-instance example-db

Updated Configuration:

  1. Creates a jar file spanner-google-cloud-samples.jar (not a fat jar) under target/spanner-snippets folder. The libraries are created in the lib folder under target/spanner-snippets.
  2. With the current change, samples will be executed by running the following command.
java -jar target/spanner-snippets/spanner-google-cloud-samples.jar \
        writeusingdml test-instance example-db

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Oct 7, 2022
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2022
@harshachinta harshachinta marked this pull request as ready for review November 9, 2022 11:19
@harshachinta harshachinta requested review from a team as code owners November 9, 2022 11:19
@harshachinta
Copy link
Contributor Author

@olavloite @rajatbhatta @ansh0l
Can you please review this PR?

@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 24, 2022
rajatbhatta
rajatbhatta approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshachinta harshachinta merged commit 19058b4 into googleapis:main Dec 5, 2022
@release-please release-please bot mentioned this pull request Dec 5, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 13, 2022
@release-please
chore(main): release 6.34.0 (#2169)
6c3e3cc 
🤖 I have created a release *beep* *boop*
---


## [6.34.0](https://togithub.com/googleapis/java-spanner/compare/v6.33.0...v6.34.0) (2022-12-12)


### Features

* Setting up 6.33.x branch ([#2184](https://togithub.com/googleapis/java-spanner/issues/2184)) ([e237a21](https://togithub.com/googleapis/java-spanner/commit/e237a213cf5cb5edc338ca4e5f8ad5dd0593d2d1))


### Bug Fixes

* Remove the statement of session number limits ([#1928](https://togithub.com/googleapis/java-spanner/issues/1928)) ([ddd0625](https://togithub.com/googleapis/java-spanner/commit/ddd062527674659ca2ea73e079bca4dee62ca67f)), closes [#1927](https://togithub.com/googleapis/java-spanner/issues/1927)
* Update samples/snippets pom.xml configuration to avoid fat jar ([#2100](https://togithub.com/googleapis/java-spanner/issues/2100)) ([19058b4](https://togithub.com/googleapis/java-spanner/commit/19058b4cd324ce33e8dd52447bde2486c87d4754))
* Use a proper endpoint for DirectPath tests ([#2186](https://togithub.com/googleapis/java-spanner/issues/2186)) ([4d74a0d](https://togithub.com/googleapis/java-spanner/commit/4d74a0d8ae48e190c126ab4047b81cca117f4de1))


### Dependencies

* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.18 ([#2171](https://togithub.com/googleapis/java-spanner/issues/2171)) ([f348780](https://togithub.com/googleapis/java-spanner/commit/f3487805fe5f976596e94047c3796bc623eeae95))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.18 ([#2145](https://togithub.com/googleapis/java-spanner/issues/2145)) ([dcdd2c3](https://togithub.com/googleapis/java-spanner/commit/dcdd2c3b684e38892fac0abbdf06081e9c7d83b2))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajatbhatta rajatbhatta rajatbhatta approved these changes

@olavloite olavloite olavloite approved these changes

Assignees

@harshachinta harshachinta

Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshachinta @olavloite @rajatbhatta @Shabirmean